Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.3.X] Fix DQMOfflineConfiguration unit tests #43664

Merged
merged 2 commits into from
Jan 16, 2024
Merged

[13.3.X] Fix DQMOfflineConfiguration unit tests #43664

merged 2 commits into from
Jan 16, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 5, 2024

backport of #43586

PR description:

Fixes unit tests failures in IB (link).
from the original description at #43586 (comment)

This fixes the DQMOfflineConfiguration unit tests. Unit tests was failing as TestDQMOfflineConfigurationGotAll was suppose to not run any sequence but as now there are over 300 sequences so this tests was running the extra 3 sequences and grep 'Analyzing 0 seqs' failed. I have updated the test to properly report the error

++ sed 's|.*Analyzing *||;s| .*||'
++ grep 'Analyzing [0-9][0-9]* seqs' run.log
+ seqs=3
+ echo 'Sequences run by final DQMOfflineConfiguration: 3'
Sequences run by final DQMOfflineConfiguration: 3
+ '[' 3 -gt 0 ']'
+ echo 'Final DQMOfflineConfiguration should not run any sequences.'
Final DQMOfflineConfiguration should not run any sequences.
+ echo 'Please update parameters for TestDQMOfflineConfiguration unittest to run the extra sequences.'
Please update parameters for TestDQMOfflineConfiguration unittest run the extra sequences.
+ exit 1

PR validation:

scram b runtests_TestDQMOfflineConfigurationGotAll runs fine

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #43586

@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Jan 5, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024 •
edited
Loading

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@antoniovagnerini, @syuvivida, @rvenditti, @cmsbuild, @nothingface0, @tjavaid can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024 •
edited
Loading

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jan 5, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fea7d8/36717/summary.html
COMMIT: 095f214
CMSSW: CMSSW_13_3_X_2024-01-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43664/36717/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Jan 15, 2024

@cms-sw/dqm-l2 do you have objections to this backport?

@tjavaid
Copy link

tjavaid commented Jan 15, 2024

@cms-sw/dqm-l2 do you have objections to this backport?

Signing it now.

@tjavaid
Copy link

tjavaid commented Jan 15, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 26a57e1 into cms-sw:CMSSW_13_3_X Jan 16, 2024
10 checks passed
@mmusich mmusich deleted the unitest-dqm-config_13_3_X branch January 16, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
5 participants
@mmusich @cmsbuild @tjavaid @antoniovilela @smuzaffar